graph_builder.cpp

Go to the documentation of this file.

//===-- graph_builder.cpp - SYCL Graph Builder ------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
 
#include "detail/config.hpp"
#include <detail/context_impl.hpp>
#include <detail/event_impl.hpp>
#include <sstream>
#include <sycl/feature_test.hpp>
#if SYCL_EXT_CODEPLAY_KERNEL_FUSION
#include <detail/jit_compiler.hpp>
#endif
#include <detail/graph_impl.hpp>
#include <detail/memory_manager.hpp>
#include <detail/queue_impl.hpp>
#include <detail/scheduler/scheduler.hpp>
#include <detail/sycl_mem_obj_t.hpp>
#include <sycl/access/access.hpp>
#include <sycl/exception.hpp>
 
#include <algorithm>
#include <cstdlib>
#include <cstring>
#include <fstream>
#include <map>
#include <memory>
#include <queue>
#include <set>
#include <vector>
 
namespace sycl {
inline namespace _V1 {
namespace detail {
 
// TODO merge with LeavesCollection's version of doOverlap (see
// leaves_collection.cpp).
static bool doOverlap(const Requirement *LHS, const Requirement *RHS) {
  return (LHS->MOffsetInBytes + LHS->MAccessRange.size() * LHS->MElemSize >=
          RHS->MOffsetInBytes) ||
         (RHS->MOffsetInBytes + RHS->MAccessRange.size() * RHS->MElemSize >=
          LHS->MOffsetInBytes);
}
 
static bool sameCtx(const ContextImplPtr &LHS, const ContextImplPtr &RHS) {
  // Consider two different host contexts to be the same to avoid additional
  // allocation on the host
  return LHS == RHS || (LHS->is_host() && RHS->is_host());
}
 
static bool IsSuitableSubReq(const Requirement *Req) {
  return Req->MIsSubBuffer;
}
 
static bool isAccessModeAllowed(access::mode Required, access::mode Current) {
  switch (Current) {
  case access::mode::read:
    return (Required == Current);
  case access::mode::write:
    assert(false && "Write only access is expected to be mapped as read_write");
    return (Required == Current || Required == access::mode::discard_write);
  case access::mode::read_write:
  case access::mode::atomic:
  case access::mode::discard_write:
  case access::mode::discard_read_write:
    return true;
  }
  assert(false);
  return false;
}
 
static access::mode combineAccessModes(access::mode A, access::mode B) {
  if (A == B)
    return A;
 
  if (A == access::mode::discard_write &&
      (B == access::mode::discard_read_write || B == access::mode::write))
    return B;
 
  if (B == access::mode::discard_write &&
      (A == access::mode::discard_read_write || A == access::mode::write))
    return A;
 
  return access::mode::read_write;
}
 
Scheduler::GraphBuilder::GraphBuilder() {
  if (const char *EnvVarCStr = SYCLConfig<SYCL_PRINT_EXECUTION_GRAPH>::get()) {
    std::string GraphPrintOpts(EnvVarCStr);
    bool EnableAlways = GraphPrintOpts.find("always") != std::string::npos;
 
    if (GraphPrintOpts.find("before_addCG") != std::string::npos ||
        EnableAlways)
      MPrintOptionsArray[BeforeAddCG] = true;
    if (GraphPrintOpts.find("after_addCG") != std::string::npos || EnableAlways)
      MPrintOptionsArray[AfterAddCG] = true;
    if (GraphPrintOpts.find("before_addCopyBack") != std::string::npos ||
        EnableAlways)
      MPrintOptionsArray[BeforeAddCopyBack] = true;
    if (GraphPrintOpts.find("after_addCopyBack") != std::string::npos ||
        EnableAlways)
      MPrintOptionsArray[AfterAddCopyBack] = true;
    if (GraphPrintOpts.find("before_addHostAcc") != std::string::npos ||
        EnableAlways)
      MPrintOptionsArray[BeforeAddHostAcc] = true;
    if (GraphPrintOpts.find("after_addHostAcc") != std::string::npos ||
        EnableAlways)
      MPrintOptionsArray[AfterAddHostAcc] = true;
    if (GraphPrintOpts.find("after_fusionComplete") != std::string::npos ||
        EnableAlways)
      MPrintOptionsArray[AfterFusionComplete] = true;
    if (GraphPrintOpts.find("after_fusionCancel") != std::string::npos ||
        EnableAlways)
      MPrintOptionsArray[AfterFusionCancel] = true;
  }
}
 
static bool markNodeAsVisited(Command *Cmd, std::vector<Command *> &Visited) {
  assert(Cmd && "Cmd can't be nullptr");
  if (Cmd->MMarks.MVisited)
    return false;
  Cmd->MMarks.MVisited = true;
  Visited.push_back(Cmd);
  return true;
}
 
static void unmarkVisitedNodes(std::vector<Command *> &Visited) {
  for (Command *Cmd : Visited)
    Cmd->MMarks.MVisited = false;
}
 
static void handleVisitedNodes(std::vector<Command *> &Visited) {
  for (Command *Cmd : Visited) {
    if (Cmd->MMarks.MToBeDeleted) {
      if (Cmd->getType() == Command::FUSION &&
          !static_cast<KernelFusionCommand *>(Cmd)->readyForDeletion()) {
        // Fusion commands might still be needed because fusion might be
        // aborted, but a later call to complete_fusion still needs to be able
        // to return a valid event. Clean-up of fusion commands is therefore
        // explicitly handled by start fusion.
        return;
      }
      Cmd->getEvent()->setCommand(nullptr);
      delete Cmd;
    } else
      Cmd->MMarks.MVisited = false;
  }
}
 
static void printDotRecursive(std::fstream &Stream,
                              std::vector<Command *> &Visited, Command *Cmd) {
  if (!markNodeAsVisited(Cmd, Visited))
    return;
  for (Command *User : Cmd->MUsers) {
    if (User)
      printDotRecursive(Stream, Visited, User);
  }
  Cmd->printDot(Stream);
}
 
void Scheduler::GraphBuilder::printGraphAsDot(const char *ModeName) {
  static size_t Counter = 0;
  std::string ModeNameStr(ModeName);
  std::string FileName =
      "graph_" + std::to_string(Counter) + ModeNameStr + ".dot";
 
  Counter++;
 
  std::fstream Stream(FileName, std::ios::out);
  Stream << "strict digraph {" << std::endl;
 
  MVisitedCmds.clear();
 
  for (SYCLMemObjI *MemObject : MMemObjs)
    for (Command *AllocaCmd : MemObject->MRecord->MAllocaCommands)
      printDotRecursive(Stream, MVisitedCmds, AllocaCmd);
 
  Stream << "}" << std::endl;
 
  unmarkVisitedNodes(MVisitedCmds);
}
 
MemObjRecord *Scheduler::GraphBuilder::getMemObjRecord(SYCLMemObjI *MemObject) {
  return MemObject->MRecord.get();
}
 
MemObjRecord *Scheduler::GraphBuilder::getOrInsertMemObjRecord(
    const QueueImplPtr &Queue, const Requirement *Req,
    std::vector<Command *> &ToEnqueue) {
  SYCLMemObjI *MemObject = Req->MSYCLMemObj;
  MemObjRecord *Record = getMemObjRecord(MemObject);
 
  if (nullptr != Record)
    return Record;
 
  const size_t LeafLimit = 8;
  LeavesCollection::AllocateDependencyF AllocateDependency =
      [this](Command *Dependant, Command *Dependency, MemObjRecord *Record,
             LeavesCollection::EnqueueListT &ToEnqueue) {
        // Add the old leaf as a dependency for the new one by duplicating one
        // of the requirements for the current record
        DepDesc Dep = findDepForRecord(Dependant, Record);
        Dep.MDepCommand = Dependency;
        std::vector<Command *> ToCleanUp;
        Command *ConnectionCmd = Dependant->addDep(Dep, ToCleanUp);
        if (ConnectionCmd)
          ToEnqueue.push_back(ConnectionCmd);
 
        --(Dependency->MLeafCounter);
        if (Dependency->readyForCleanup())
          ToCleanUp.push_back(Dependency);
        for (Command *Cmd : ToCleanUp)
          cleanupCommand(Cmd);
      };
 
  const ContextImplPtr &InteropCtxPtr = Req->MSYCLMemObj->getInteropContext();
  if (InteropCtxPtr) {
    // The memory object has been constructed using interoperability constructor
    // which means that there is already an allocation(cl_mem) in some context.
    // Registering this allocation in the SYCL graph.
 
    std::vector<sycl::device> Devices =
        InteropCtxPtr->get_info<info::context::devices>();
    assert(Devices.size() != 0);
    DeviceImplPtr Dev = detail::getSyclObjImpl(Devices[0]);
 
    // Since all the Scheduler commands require queue but we have only context
    // here, we need to create a dummy queue bound to the context and one of the
    // devices from the context.
    QueueImplPtr InteropQueuePtr{new detail::queue_impl{
        Dev, InteropCtxPtr, /*AsyncHandler=*/{}, /*PropertyList=*/{}}};
 
    MemObject->MRecord.reset(
        new MemObjRecord{InteropCtxPtr, LeafLimit, AllocateDependency});
    getOrCreateAllocaForReq(MemObject->MRecord.get(), Req, InteropQueuePtr,
                            ToEnqueue);
  } else
    MemObject->MRecord.reset(new MemObjRecord{Queue->getContextImplPtr(),
                                              LeafLimit, AllocateDependency});
 
  MMemObjs.push_back(MemObject);
  return MemObject->MRecord.get();
}
 
void Scheduler::GraphBuilder::updateLeaves(const std::set<Command *> &Cmds,
                                           MemObjRecord *Record,
                                           access::mode AccessMode,
                                           std::vector<Command *> &ToCleanUp) {
 
  const bool ReadOnlyReq = AccessMode == access::mode::read;
  if (ReadOnlyReq)
    return;
 
  for (Command *Cmd : Cmds) {
    bool WasLeaf = Cmd->MLeafCounter > 0;
    Cmd->MLeafCounter -= Record->MReadLeaves.remove(Cmd);
    Cmd->MLeafCounter -= Record->MWriteLeaves.remove(Cmd);
    if (WasLeaf && Cmd->readyForCleanup()) {
      ToCleanUp.push_back(Cmd);
    }
  }
}
 
void Scheduler::GraphBuilder::addNodeToLeaves(
    MemObjRecord *Record, Command *Cmd, access::mode AccessMode,
    std::vector<Command *> &ToEnqueue) {
  LeavesCollection &Leaves{AccessMode == access::mode::read
                               ? Record->MReadLeaves
                               : Record->MWriteLeaves};
  if (Leaves.push_back(Cmd, ToEnqueue))
    ++Cmd->MLeafCounter;
}
 
UpdateHostRequirementCommand *Scheduler::GraphBuilder::insertUpdateHostReqCmd(
    MemObjRecord *Record, Requirement *Req, const QueueImplPtr &Queue,
    std::vector<Command *> &ToEnqueue) {
  AllocaCommandBase *AllocaCmd =
      findAllocaForReq(Record, Req, Queue->getContextImplPtr());
  assert(AllocaCmd && "There must be alloca for requirement!");
  UpdateHostRequirementCommand *UpdateCommand =
      new UpdateHostRequirementCommand(Queue, *Req, AllocaCmd, &Req->MData);
  // Need copy of requirement because after host accessor destructor call
  // dependencies become invalid if requirement is stored by pointer.
  const Requirement *StoredReq = UpdateCommand->getRequirement();
 
  std::set<Command *> Deps =
      findDepsForReq(Record, Req, Queue->getContextImplPtr());
  std::vector<Command *> ToCleanUp;
  for (Command *Dep : Deps) {
    Command *ConnCmd =
        UpdateCommand->addDep(DepDesc{Dep, StoredReq, AllocaCmd}, ToCleanUp);
    if (ConnCmd)
      ToEnqueue.push_back(ConnCmd);
  }
  updateLeaves(Deps, Record, Req->MAccessMode, ToCleanUp);
  addNodeToLeaves(Record, UpdateCommand, Req->MAccessMode, ToEnqueue);
  for (Command *Cmd : ToCleanUp)
    cleanupCommand(Cmd);
  return UpdateCommand;
}
 
// Takes linked alloca commands. Makes AllocaCmdDst command active using map
// or unmap operation.
static Command *insertMapUnmapForLinkedCmds(AllocaCommandBase *AllocaCmdSrc,
                                            AllocaCommandBase *AllocaCmdDst,
                                            access::mode MapMode) {
  assert(AllocaCmdSrc->MLinkedAllocaCmd == AllocaCmdDst &&
         "Expected linked alloca commands");
  assert(AllocaCmdSrc->MIsActive &&
         "Expected source alloca command to be active");
 
  if (AllocaCmdSrc->getQueue()->is_host()) {
    UnMapMemObject *UnMapCmd = new UnMapMemObject(
        AllocaCmdDst, *AllocaCmdDst->getRequirement(),
        &AllocaCmdSrc->MMemAllocation, AllocaCmdDst->getQueue());
 
    std::swap(AllocaCmdSrc->MIsActive, AllocaCmdDst->MIsActive);
 
    return UnMapCmd;
  }
 
  MapMemObject *MapCmd = new MapMemObject(
      AllocaCmdSrc, *AllocaCmdSrc->getRequirement(),
      &AllocaCmdDst->MMemAllocation, AllocaCmdSrc->getQueue(), MapMode);
 
  std::swap(AllocaCmdSrc->MIsActive, AllocaCmdDst->MIsActive);
 
  return MapCmd;
}
 
Command *Scheduler::GraphBuilder::insertMemoryMove(
    MemObjRecord *Record, Requirement *Req, const QueueImplPtr &Queue,
    std::vector<Command *> &ToEnqueue) {
 
  AllocaCommandBase *AllocaCmdDst =
      getOrCreateAllocaForReq(Record, Req, Queue, ToEnqueue);
  if (!AllocaCmdDst)
    throw runtime_error("Out of host memory", PI_ERROR_OUT_OF_HOST_MEMORY);
 
  std::set<Command *> Deps =
      findDepsForReq(Record, Req, Queue->getContextImplPtr());
  Deps.insert(AllocaCmdDst);
  // Get parent allocation of sub buffer to perform full copy of whole buffer
  if (IsSuitableSubReq(Req)) {
    if (AllocaCmdDst->getType() == Command::CommandType::ALLOCA_SUB_BUF)
      AllocaCmdDst =
          static_cast<AllocaSubBufCommand *>(AllocaCmdDst)->getParentAlloca();
  }
 
  AllocaCommandBase *AllocaCmdSrc =
      findAllocaForReq(Record, Req, Record->MCurContext);
  if (!AllocaCmdSrc && IsSuitableSubReq(Req)) {
    // Since no alloca command for the sub buffer requirement was found in the
    // current context, need to find a parent alloca command for it (it must be
    // there)
    auto IsSuitableAlloca = [Record](AllocaCommandBase *AllocaCmd) {
      bool Res = sameCtx(AllocaCmd->getQueue()->getContextImplPtr(),
                         Record->MCurContext) &&
                 // Looking for a parent buffer alloca command
                 AllocaCmd->getType() == Command::CommandType::ALLOCA;
      return Res;
    };
    const auto It =
        std::find_if(Record->MAllocaCommands.begin(),
                     Record->MAllocaCommands.end(), IsSuitableAlloca);
    AllocaCmdSrc = (Record->MAllocaCommands.end() != It) ? *It : nullptr;
  }
  if (!AllocaCmdSrc)
    throw runtime_error("Cannot find buffer allocation",
                        PI_ERROR_INVALID_VALUE);
  // Get parent allocation of sub buffer to perform full copy of whole buffer
  if (IsSuitableSubReq(Req)) {
    if (AllocaCmdSrc->getType() == Command::CommandType::ALLOCA_SUB_BUF)
      AllocaCmdSrc =
          static_cast<AllocaSubBufCommand *>(AllocaCmdSrc)->getParentAlloca();
    else if (AllocaCmdSrc->getSYCLMemObj() != Req->MSYCLMemObj)
      assert(false && "Inappropriate alloca command.");
  }
 
  Command *NewCmd = nullptr;
 
  if (AllocaCmdSrc->MLinkedAllocaCmd == AllocaCmdDst) {
    // Map write only as read-write
    access::mode MapMode = Req->MAccessMode;
    if (MapMode == access::mode::write)
      MapMode = access::mode::read_write;
    NewCmd = insertMapUnmapForLinkedCmds(AllocaCmdSrc, AllocaCmdDst, MapMode);
    Record->MHostAccess = MapMode;
  } else {
 
    if ((Req->MAccessMode == access::mode::discard_write) ||
        (Req->MAccessMode == access::mode::discard_read_write)) {
      Record->MCurContext = Queue->getContextImplPtr();
      return nullptr;
    } else {
      // Full copy of buffer is needed to avoid loss of data that may be caused
      // by copying specific range from host to device and backwards.
      NewCmd =
          new MemCpyCommand(*AllocaCmdSrc->getRequirement(), AllocaCmdSrc,
                            *AllocaCmdDst->getRequirement(), AllocaCmdDst,
                            AllocaCmdSrc->getQueue(), AllocaCmdDst->getQueue());
    }
  }
  std::vector<Command *> ToCleanUp;
  for (Command *Dep : Deps) {
    Command *ConnCmd = NewCmd->addDep(
        DepDesc{Dep, NewCmd->getRequirement(), AllocaCmdDst}, ToCleanUp);
    if (ConnCmd)
      ToEnqueue.push_back(ConnCmd);
  }
  updateLeaves(Deps, Record, access::mode::read_write, ToCleanUp);
  addNodeToLeaves(Record, NewCmd, access::mode::read_write, ToEnqueue);
  for (Command *Cmd : ToCleanUp)
    cleanupCommand(Cmd);
  Record->MCurContext = Queue->getContextImplPtr();
  return NewCmd;
}
 
Command *Scheduler::GraphBuilder::remapMemoryObject(
    MemObjRecord *Record, Requirement *Req, AllocaCommandBase *HostAllocaCmd,
    std::vector<Command *> &ToEnqueue) {
  assert(HostAllocaCmd->getQueue()->is_host() &&
         "Host alloca command expected");
  assert(HostAllocaCmd->MIsActive && "Active alloca command expected");
 
  AllocaCommandBase *LinkedAllocaCmd = HostAllocaCmd->MLinkedAllocaCmd;
  assert(LinkedAllocaCmd && "Linked alloca command expected");
 
  std::set<Command *> Deps = findDepsForReq(Record, Req, Record->MCurContext);
 
  UnMapMemObject *UnMapCmd = new UnMapMemObject(
      LinkedAllocaCmd, *LinkedAllocaCmd->getRequirement(),
      &HostAllocaCmd->MMemAllocation, LinkedAllocaCmd->getQueue());
 
  // Map write only as read-write
  access::mode MapMode = Req->MAccessMode;
  if (MapMode == access::mode::write)
    MapMode = access::mode::read_write;
  MapMemObject *MapCmd = new MapMemObject(
      LinkedAllocaCmd, *LinkedAllocaCmd->getRequirement(),
      &HostAllocaCmd->MMemAllocation, LinkedAllocaCmd->getQueue(), MapMode);
 
  std::vector<Command *> ToCleanUp;
  for (Command *Dep : Deps) {
    Command *ConnCmd = UnMapCmd->addDep(
        DepDesc{Dep, UnMapCmd->getRequirement(), LinkedAllocaCmd}, ToCleanUp);
    if (ConnCmd)
      ToEnqueue.push_back(ConnCmd);
  }
 
  Command *ConnCmd = MapCmd->addDep(
      DepDesc{UnMapCmd, MapCmd->getRequirement(), HostAllocaCmd}, ToCleanUp);
  if (ConnCmd)
    ToEnqueue.push_back(ConnCmd);
 
  updateLeaves(Deps, Record, access::mode::read_write, ToCleanUp);
  addNodeToLeaves(Record, MapCmd, access::mode::read_write, ToEnqueue);
  for (Command *Cmd : ToCleanUp)
    cleanupCommand(Cmd);
  Record->MHostAccess = MapMode;
  return MapCmd;
}
 
// The function adds copy operation of the up to date'st memory to the memory
// pointed by Req.
Command *
Scheduler::GraphBuilder::addCopyBack(Requirement *Req,
                                     std::vector<Command *> &ToEnqueue) {
  QueueImplPtr HostQueue = Scheduler::getInstance().getDefaultHostQueue();
  SYCLMemObjI *MemObj = Req->MSYCLMemObj;
  MemObjRecord *Record = getMemObjRecord(MemObj);
  if (Record && MPrintOptionsArray[BeforeAddCopyBack])
    printGraphAsDot("before_addCopyBack");
 
  // Do nothing if there were no or only read operations with the memory object.
  if (nullptr == Record || !Record->MMemModified)
    return nullptr;
 
  std::set<Command *> Deps =
      findDepsForReq(Record, Req, HostQueue->getContextImplPtr());
  AllocaCommandBase *SrcAllocaCmd =
      findAllocaForReq(Record, Req, Record->MCurContext);
 
  auto MemCpyCmdUniquePtr = std::make_unique<MemCpyCommandHost>(
      *SrcAllocaCmd->getRequirement(), SrcAllocaCmd, *Req, &Req->MData,
      SrcAllocaCmd->getQueue(), std::move(HostQueue));
 
  if (!MemCpyCmdUniquePtr)
    throw runtime_error("Out of host memory", PI_ERROR_OUT_OF_HOST_MEMORY);
 
  MemCpyCommandHost *MemCpyCmd = MemCpyCmdUniquePtr.release();
 
  std::vector<Command *> ToCleanUp;
  for (Command *Dep : Deps) {
    Command *ConnCmd = MemCpyCmd->addDep(
        DepDesc{Dep, MemCpyCmd->getRequirement(), SrcAllocaCmd}, ToCleanUp);
    if (ConnCmd)
      ToEnqueue.push_back(ConnCmd);
  }
 
  updateLeaves(Deps, Record, Req->MAccessMode, ToCleanUp);
  addNodeToLeaves(Record, MemCpyCmd, Req->MAccessMode, ToEnqueue);
  for (Command *Cmd : ToCleanUp)
    cleanupCommand(Cmd);
  if (MPrintOptionsArray[AfterAddCopyBack])
    printGraphAsDot("after_addCopyBack");
  return MemCpyCmd;
}
 
// The function implements SYCL host accessor logic: host accessor
// should provide access to the buffer in user space.
Command *
Scheduler::GraphBuilder::addHostAccessor(Requirement *Req,
                                         std::vector<Command *> &ToEnqueue) {
 
  if (Req->MAccessMode != sycl::access_mode::read) {
    auto SYCLMemObj = static_cast<detail::SYCLMemObjT *>(Req->MSYCLMemObj);
    SYCLMemObj->handleWriteAccessorCreation();
  }
 
  const QueueImplPtr &HostQueue = getInstance().getDefaultHostQueue();
 
  MemObjRecord *Record = getOrInsertMemObjRecord(HostQueue, Req, ToEnqueue);
  if (MPrintOptionsArray[BeforeAddHostAcc])
    printGraphAsDot("before_addHostAccessor");
  markModifiedIfWrite(Record, Req);
 
  AllocaCommandBase *HostAllocaCmd =
      getOrCreateAllocaForReq(Record, Req, HostQueue, ToEnqueue);
 
  if (sameCtx(HostAllocaCmd->getQueue()->getContextImplPtr(),
              Record->MCurContext)) {
    if (!isAccessModeAllowed(Req->MAccessMode, Record->MHostAccess)) {
      remapMemoryObject(Record, Req,
                        Req->MIsSubBuffer ? (static_cast<AllocaSubBufCommand *>(
                                                 HostAllocaCmd))
                                                ->getParentAlloca()
                                          : HostAllocaCmd,
                        ToEnqueue);
    }
  } else
    insertMemoryMove(Record, Req, HostQueue, ToEnqueue);
 
  Command *UpdateHostAccCmd =
      insertUpdateHostReqCmd(Record, Req, HostQueue, ToEnqueue);
 
  // Need empty command to be blocked until host accessor is destructed
  EmptyCommand *EmptyCmd =
      addEmptyCmd(UpdateHostAccCmd, {Req}, HostQueue,
                  Command::BlockReason::HostAccessor, ToEnqueue);
 
  Req->MBlockedCmd = EmptyCmd;
 
  if (MPrintOptionsArray[AfterAddHostAcc])
    printGraphAsDot("after_addHostAccessor");
 
  return UpdateHostAccCmd;
}
 
Command *Scheduler::GraphBuilder::addCGUpdateHost(
    std::unique_ptr<detail::CG> CommandGroup, const QueueImplPtr &HostQueue,
    std::vector<Command *> &ToEnqueue) {
 
  auto UpdateHost = static_cast<CGUpdateHost *>(CommandGroup.get());
  Requirement *Req = UpdateHost->getReqToUpdate();
 
  MemObjRecord *Record = getOrInsertMemObjRecord(HostQueue, Req, ToEnqueue);
  return insertMemoryMove(Record, Req, HostQueue, ToEnqueue);
}
 
std::set<Command *>
Scheduler::GraphBuilder::findDepsForReq(MemObjRecord *Record,
                                        const Requirement *Req,
                                        const ContextImplPtr &Context) {
  std::set<Command *> RetDeps;
  std::vector<Command *> Visited;
  const bool ReadOnlyReq = Req->MAccessMode == access::mode::read;
 
  std::vector<Command *> ToAnalyze{Record->MWriteLeaves.toVector()};
 
  if (!ReadOnlyReq) {
    std::vector<Command *> V{Record->MReadLeaves.toVector()};
 
    ToAnalyze.insert(ToAnalyze.begin(), V.begin(), V.end());
  }
 
  while (!ToAnalyze.empty()) {
    Command *DepCmd = ToAnalyze.back();
    ToAnalyze.pop_back();
 
    std::vector<Command *> NewAnalyze;
 
    for (const DepDesc &Dep : DepCmd->MDeps) {
      if (Dep.MDepRequirement->MSYCLMemObj != Req->MSYCLMemObj)
        continue;
 
      bool CanBypassDep = false;
      // If both only read
      CanBypassDep |=
          Dep.MDepRequirement->MAccessMode == access::mode::read && ReadOnlyReq;
 
      // If not overlap
      CanBypassDep |= !doOverlap(Dep.MDepRequirement, Req);
 
      // Going through copying memory between contexts is not supported.
      if (Dep.MDepCommand)
        CanBypassDep &=
            sameCtx(Context, Dep.MDepCommand->getQueue()->getContextImplPtr());
 
      if (!CanBypassDep) {
        RetDeps.insert(DepCmd);
        // No need to analyze deps of examining command as it's dependency
        // itself.
        NewAnalyze.clear();
        break;
      }
 
      if (markNodeAsVisited(Dep.MDepCommand, Visited))
        NewAnalyze.push_back(Dep.MDepCommand);
    }
    ToAnalyze.insert(ToAnalyze.end(), NewAnalyze.begin(), NewAnalyze.end());
  }
  unmarkVisitedNodes(Visited);
  return RetDeps;
}
 
// A helper function for finding a command dependency on a specific memory
// object
DepDesc Scheduler::GraphBuilder::findDepForRecord(Command *Cmd,
                                                  MemObjRecord *Record) {
  for (const DepDesc &DD : Cmd->MDeps) {
    if (getMemObjRecord(DD.MDepRequirement->MSYCLMemObj) == Record) {
      return DD;
    }
  }
  assert(false && "No dependency found for a leaf of the record");
  return {nullptr, nullptr, nullptr};
}
 
// The function searches for the alloca command matching context and
// requirement.
AllocaCommandBase *Scheduler::GraphBuilder::findAllocaForReq(
    MemObjRecord *Record, const Requirement *Req, const ContextImplPtr &Context,
    bool AllowConst) {
  auto IsSuitableAlloca = [&Context, Req,
                           AllowConst](AllocaCommandBase *AllocaCmd) {
    bool Res = sameCtx(AllocaCmd->getQueue()->getContextImplPtr(), Context);
    if (IsSuitableSubReq(Req)) {
      const Requirement *TmpReq = AllocaCmd->getRequirement();
      Res &= AllocaCmd->getType() == Command::CommandType::ALLOCA_SUB_BUF;
      Res &= TmpReq->MOffsetInBytes == Req->MOffsetInBytes;
      Res &= TmpReq->MAccessRange == Req->MAccessRange;
      Res &= AllowConst || !AllocaCmd->MIsConst;
    }
    return Res;
  };
  const auto It = std::find_if(Record->MAllocaCommands.begin(),
                               Record->MAllocaCommands.end(), IsSuitableAlloca);
  return (Record->MAllocaCommands.end() != It) ? *It : nullptr;
}
 
static bool checkHostUnifiedMemory(const ContextImplPtr &Ctx) {
  if (const char *HUMConfig = SYCLConfig<SYCL_HOST_UNIFIED_MEMORY>::get()) {
    if (std::strcmp(HUMConfig, "0") == 0)
      return Ctx->is_host();
    if (std::strcmp(HUMConfig, "1") == 0)
      return true;
  }
  for (const device &Device : Ctx->getDevices()) {
    if (!Device.get_info<info::device::host_unified_memory>())
      return false;
  }
  return true;
}
 
// The function searches for the alloca command matching context and
// requirement. If none exists, new allocation command is created.
// Note, creation of new allocation command can lead to the current context
// (Record->MCurContext) change.
AllocaCommandBase *Scheduler::GraphBuilder::getOrCreateAllocaForReq(
    MemObjRecord *Record, const Requirement *Req, const QueueImplPtr &Queue,
    std::vector<Command *> &ToEnqueue) {
 
  AllocaCommandBase *AllocaCmd = findAllocaForReq(
      Record, Req, Queue->getContextImplPtr(), /*AllowConst=*/false);
 
  if (!AllocaCmd) {
    std::vector<Command *> ToCleanUp;
    if (IsSuitableSubReq(Req)) {
      // Get parent requirement. It's hard to get right parents' range
      // so full parent requirement has range represented in bytes
      range<3> ParentRange{Req->MSYCLMemObj->getSizeInBytes(), 1, 1};
      Requirement ParentRequirement(
          /*Offset*/ {0, 0, 0}, ParentRange, ParentRange,
          access::mode::read_write, Req->MSYCLMemObj, /*Dims*/ 1,
          /*Working with bytes*/ sizeof(char), /*offset*/ size_t(0));
 
      auto *ParentAlloca =
          getOrCreateAllocaForReq(Record, &ParentRequirement, Queue, ToEnqueue);
      AllocaCmd = new AllocaSubBufCommand(Queue, *Req, ParentAlloca, ToEnqueue,
                                          ToCleanUp);
    } else {
 
      const Requirement FullReq(/*Offset*/ {0, 0, 0}, Req->MMemoryRange,
                                Req->MMemoryRange, access::mode::read_write,
                                Req->MSYCLMemObj, Req->MDims, Req->MElemSize,
                                0 /*ReMOffsetInBytes*/, false /*MIsSubBuffer*/);
      // Can reuse user data for the first allocation. Do so if host unified
      // memory is supported regardless of the access mode (the pointer will be
      // reused). For devices without host unified memory the initialization
      // will be performed as a write operation.
      // TODO the case where the first alloca is made with a discard mode and
      // the user pointer is read-only is still not handled: it leads to
      // unnecessary copy on devices with unified host memory support.
      const bool HostUnifiedMemory =
          checkHostUnifiedMemory(Queue->getContextImplPtr());
      SYCLMemObjI *MemObj = Req->MSYCLMemObj;
      const bool InitFromUserData = Record->MAllocaCommands.empty() &&
                                    (HostUnifiedMemory || MemObj->isInterop());
      AllocaCommandBase *LinkedAllocaCmd = nullptr;
 
      // For the first allocation on a device without host unified memory we
      // might need to also create a host alloca right away in order to perform
      // the initial memory write.
      if (Record->MAllocaCommands.empty()) {
        if (!HostUnifiedMemory &&
            Req->MAccessMode != access::mode::discard_write &&
            Req->MAccessMode != access::mode::discard_read_write) {
          // There's no need to make a host allocation if the buffer is not
          // initialized with user data.
          if (MemObj->hasUserDataPtr()) {
            QueueImplPtr DefaultHostQueue =
                Scheduler::getInstance().getDefaultHostQueue();
            AllocaCommand *HostAllocaCmd = new AllocaCommand(
                DefaultHostQueue, FullReq, true /* InitFromUserData */,
                nullptr /* LinkedAllocaCmd */,
                MemObj->isHostPointerReadOnly() /* IsConst */);
            Record->MAllocaCommands.push_back(HostAllocaCmd);
            Record->MWriteLeaves.push_back(HostAllocaCmd, ToEnqueue);
            ++(HostAllocaCmd->MLeafCounter);
            Record->MCurContext = DefaultHostQueue->getContextImplPtr();
          }
        }
      } else {
        // If it is not the first allocation, try to setup a link
        // FIXME: Temporary limitation, linked alloca commands for an image is
        // not supported because map operation is not implemented for an image.
        if (Req->MSYCLMemObj->getType() == SYCLMemObjI::MemObjType::Buffer)
          // Current limitation is to setup link between current allocation and
          // new one. There could be situations when we could setup link with
          // "not" current allocation, but it will require memory copy.
          // Can setup link between cl and host allocations only
          if (Queue->is_host() != Record->MCurContext->is_host()) {
            // Linked commands assume that the host allocation is reused by the
            // plugin runtime and that can lead to unnecessary copy overhead on
            // devices that do not support host unified memory. Do not link the
            // allocations in this case.
            // However, if the user explicitly requests use of pinned host
            // memory, map/unmap operations are expected to work faster than
            // read/write from/to an artbitrary host pointer. Link such commands
            // regardless of host unified memory support.
            bool PinnedHostMemory = MemObj->usesPinnedHostMemory();
 
            bool HostUnifiedMemoryOnNonHostDevice =
                Queue->is_host() ? checkHostUnifiedMemory(Record->MCurContext)
                                 : HostUnifiedMemory;
            if (PinnedHostMemory || HostUnifiedMemoryOnNonHostDevice) {
              AllocaCommandBase *LinkedAllocaCmdCand = findAllocaForReq(
                  Record, Req, Record->MCurContext, /*AllowConst=*/false);
 
              // Cannot setup link if candidate is linked already
              if (LinkedAllocaCmdCand &&
                  !LinkedAllocaCmdCand->MLinkedAllocaCmd) {
                LinkedAllocaCmd = LinkedAllocaCmdCand;
              }
            }
          }
      }
 
      AllocaCmd =
          new AllocaCommand(Queue, FullReq, InitFromUserData, LinkedAllocaCmd);
 
      // Update linked command
      if (LinkedAllocaCmd) {
        Command *ConnCmd = AllocaCmd->addDep(
            DepDesc{LinkedAllocaCmd, AllocaCmd->getRequirement(),
                    LinkedAllocaCmd},
            ToCleanUp);
        if (ConnCmd)
          ToEnqueue.push_back(ConnCmd);
        LinkedAllocaCmd->MLinkedAllocaCmd = AllocaCmd;
 
        // To ensure that the leader allocation is removed first
        ConnCmd = AllocaCmd->getReleaseCmd()->addDep(
            DepDesc(LinkedAllocaCmd->getReleaseCmd(),
                    AllocaCmd->getRequirement(), LinkedAllocaCmd),
            ToCleanUp);
        if (ConnCmd)
          ToEnqueue.push_back(ConnCmd);
 
        // Device allocation takes ownership of the host ptr during
        // construction, host allocation doesn't. So, device allocation should
        // always be active here. Also if the "follower" command is a device one
        // we have to change current context to the device one.
        if (Queue->is_host()) {
          AllocaCmd->MIsActive = false;
        } else {
          LinkedAllocaCmd->MIsActive = false;
          Record->MCurContext = Queue->getContextImplPtr();
 
          std::set<Command *> Deps =
              findDepsForReq(Record, Req, Queue->getContextImplPtr());
          for (Command *Dep : Deps) {
            Command *ConnCmd = AllocaCmd->addDep(
                DepDesc{Dep, Req, LinkedAllocaCmd}, ToCleanUp);
            if (ConnCmd)
              ToEnqueue.push_back(ConnCmd);
          }
          updateLeaves(Deps, Record, Req->MAccessMode, ToCleanUp);
          addNodeToLeaves(Record, AllocaCmd, Req->MAccessMode, ToEnqueue);
        }
      }
    }
 
    Record->MAllocaCommands.push_back(AllocaCmd);
    Record->MWriteLeaves.push_back(AllocaCmd, ToEnqueue);
    ++(AllocaCmd->MLeafCounter);
    for (Command *Cmd : ToCleanUp)
      cleanupCommand(Cmd);
  }
  return AllocaCmd;
}
 
// The function sets MemModified flag in record if requirement has write access.
void Scheduler::GraphBuilder::markModifiedIfWrite(MemObjRecord *Record,
                                                  Requirement *Req) {
  switch (Req->MAccessMode) {
  case access::mode::write:
  case access::mode::read_write:
  case access::mode::discard_write:
  case access::mode::discard_read_write:
  case access::mode::atomic:
    Record->MMemModified = true;
    break;
  case access::mode::read:
    break;
  }
}
 
EmptyCommand *Scheduler::GraphBuilder::addEmptyCmd(
    Command *Cmd, const std::vector<Requirement *> &Reqs,
    const QueueImplPtr &Queue, Command::BlockReason Reason,
    std::vector<Command *> &ToEnqueue, const bool AddDepsToLeaves) {
  EmptyCommand *EmptyCmd =
      new EmptyCommand(Scheduler::getInstance().getDefaultHostQueue());
 
  if (!EmptyCmd)
    throw runtime_error("Out of host memory", PI_ERROR_OUT_OF_HOST_MEMORY);
 
  EmptyCmd->MIsBlockable = true;
  EmptyCmd->MEnqueueStatus = EnqueueResultT::SyclEnqueueBlocked;
  EmptyCmd->MBlockReason = Reason;
 
  for (Requirement *Req : Reqs) {
    MemObjRecord *Record = getOrInsertMemObjRecord(Queue, Req, ToEnqueue);
    AllocaCommandBase *AllocaCmd =
        getOrCreateAllocaForReq(Record, Req, Queue, ToEnqueue);
    EmptyCmd->addRequirement(Cmd, AllocaCmd, Req);
  }
  // addRequirement above call addDep that already will add EmptyCmd as user for
  // Cmd no Reqs size check here so assume it is possible to have no Reqs passed
  if (!Reqs.size())
    Cmd->addUser(EmptyCmd);
 
  if (AddDepsToLeaves) {
    const std::vector<DepDesc> &Deps = Cmd->MDeps;
    std::vector<Command *> ToCleanUp;
    for (const DepDesc &Dep : Deps) {
      const Requirement *Req = Dep.MDepRequirement;
      MemObjRecord *Record = getMemObjRecord(Req->MSYCLMemObj);
 
      updateLeaves({Cmd}, Record, Req->MAccessMode, ToCleanUp);
      addNodeToLeaves(Record, EmptyCmd, Req->MAccessMode, ToEnqueue);
    }
    for (Command *Cmd : ToCleanUp)
      cleanupCommand(Cmd);
  }
 
  return EmptyCmd;
}
 
static bool isInteropHostTask(ExecCGCommand *Cmd) {
  if (Cmd->getCG().getType() != CG::CGTYPE::CodeplayHostTask)
    return false;
 
  const detail::CGHostTask &HT =
      static_cast<detail::CGHostTask &>(Cmd->getCG());
 
  return HT.MHostTask->isInteropTask();
}
 
static void combineAccessModesOfReqs(std::vector<Requirement *> &Reqs) {
  std::unordered_map<SYCLMemObjI *, access::mode> CombinedModes;
  bool HasDuplicateMemObjects = false;
  for (const Requirement *Req : Reqs) {
    auto Result = CombinedModes.insert(
        std::make_pair(Req->MSYCLMemObj, Req->MAccessMode));
    if (!Result.second) {
      Result.first->second =
          combineAccessModes(Result.first->second, Req->MAccessMode);
      HasDuplicateMemObjects = true;
    }
  }
 
  if (!HasDuplicateMemObjects)
    return;
  for (Requirement *Req : Reqs) {
    Req->MAccessMode = CombinedModes[Req->MSYCLMemObj];
  }
}
 
Scheduler::GraphBuildResult Scheduler::GraphBuilder::addCG(
    std::unique_ptr<detail::CG> CommandGroup, const QueueImplPtr &Queue,
    std::vector<Command *> &ToEnqueue,
    sycl::detail::pi::PiExtCommandBuffer CommandBuffer,
    const std::vector<sycl::detail::pi::PiExtSyncPoint> &Dependencies) {
  std::vector<Requirement *> &Reqs = CommandGroup->getRequirements();
  std::vector<detail::EventImplPtr> &Events = CommandGroup->getEvents();
 
  auto NewCmd = std::make_unique<ExecCGCommand>(
      std::move(CommandGroup), Queue, CommandBuffer, std::move(Dependencies));
 
  if (!NewCmd)
    throw runtime_error("Out of host memory", PI_ERROR_OUT_OF_HOST_MEMORY);
 
  // Only device kernel command groups can participate in fusion. Otherwise,
  // command groups take the regular route. If they create any requirement or
  // event dependency on any of the kernels in the fusion list, this will lead
  // to cancellation of the fusion in the GraphProcessor.
  auto QUniqueID = std::hash<sycl::detail::queue_impl *>()(Queue.get());
  if (isInFusionMode(QUniqueID)) {
    if (NewCmd->isFusable()) {
      auto *FusionCmd = findFusionList(QUniqueID)->second.get();
 
      bool dependsOnFusion = false;
      for (auto Ev = Events.begin(); Ev != Events.end();) {
        auto *EvDepCmd = static_cast<Command *>((*Ev)->getCommand());
        if (!EvDepCmd) {
          ++Ev;
          continue;
        }
        // Event dependencies on commands part of another active fusion are
        // handled by cancelling fusion in that other queue.
        if (EvDepCmd->getQueue() != Queue && isPartOfActiveFusion(EvDepCmd)) {
          printFusionWarning(
              "Aborting fusion because of event dependency from a "
              "different fusion");
          cancelFusion(EvDepCmd->getQueue(), ToEnqueue);
        }
        // Check if this command depends on the placeholder command for the
        // fusion itself participates in.
        if (EvDepCmd == FusionCmd) {
          Ev = Events.erase(Ev);
          dependsOnFusion = true;
        } else {
          ++Ev;
        }
      }
 
      // If this command has an explicit event dependency on the placeholder
      // command for this fusion (because it used depends_on on the event
      // returned by submitting another kernel to this fusion earlier), add a
      // dependency on all the commands in the fusion list so far.
      if (dependsOnFusion) {
        for (auto *Cmd : FusionCmd->getFusionList()) {
          Events.push_back(Cmd->getEvent());
        }
      }
 
      // Add the kernel to the graph, but delay the enqueue of any auxiliary
      // commands (e.g., allocations) resulting from that process by adding them
      // to the list of auxiliary commands of the fusion command.
      createGraphForCommand(NewCmd.get(), NewCmd->getCG(),
                            isInteropHostTask(NewCmd.get()), Reqs, Events,
                            Queue, FusionCmd->auxiliaryCommands());
 
      // Set the fusion command, so we recognize when another command depends on
      // a kernel in the fusion list.
      FusionCmd->addToFusionList(NewCmd.get());
      NewCmd->MFusionCmd = FusionCmd;
      std::vector<Command *> ToCleanUp;
      // Add an event dependency from the fusion placeholder command to the new
      // kernel.
      auto ConnectionCmd = FusionCmd->addDep(NewCmd->getEvent(), ToCleanUp);
      if (ConnectionCmd) {
        FusionCmd->auxiliaryCommands().push_back(ConnectionCmd);
      }
      return {NewCmd.release(), FusionCmd->getEvent(), false};
    } else {
      std::string s;
      std::stringstream ss(s);
      if (NewCmd->getCG().getType() == CG::CGTYPE::Kernel) {
        ss << "Not fusing kernel with 'use_root_sync' property. Can only fuse "
              "non-cooperative device kernels.";
      } else {
        ss << "Not fusing '" << NewCmd->getTypeString()
           << "' command group. Can only fuse device kernel command groups.";
      }
      printFusionWarning(ss.str());
    }
  }
  createGraphForCommand(NewCmd.get(), NewCmd->getCG(),
                        isInteropHostTask(NewCmd.get()), Reqs, Events, Queue,
                        ToEnqueue);
  auto Event = NewCmd->getEvent();
  return {NewCmd.release(), Event, true};
}
 
void Scheduler::GraphBuilder::createGraphForCommand(
    Command *NewCmd, CG &CG, bool isInteropTask,
    std::vector<Requirement *> &Reqs,
    const std::vector<detail::EventImplPtr> &Events, QueueImplPtr Queue,
    std::vector<Command *> &ToEnqueue) {
 
  if (MPrintOptionsArray[BeforeAddCG])
    printGraphAsDot("before_addCG");
 
  // If there are multiple requirements for the same memory object, its
  // AllocaCommand creation will be dependent on the access mode of the first
  // requirement. Combine these access modes to take all of them into account.
  combineAccessModesOfReqs(Reqs);
  std::vector<Command *> ToCleanUp;
  for (Requirement *Req : Reqs) {
    MemObjRecord *Record = nullptr;
    AllocaCommandBase *AllocaCmd = nullptr;
 
    bool isSameCtx = false;
 
    {
      const QueueImplPtr &QueueForAlloca =
          isInteropTask ? static_cast<detail::CGHostTask &>(CG).MQueue : Queue;
 
      Record = getOrInsertMemObjRecord(QueueForAlloca, Req, ToEnqueue);
      markModifiedIfWrite(Record, Req);
 
      AllocaCmd =
          getOrCreateAllocaForReq(Record, Req, QueueForAlloca, ToEnqueue);
 
      isSameCtx =
          sameCtx(QueueForAlloca->getContextImplPtr(), Record->MCurContext);
    }
 
    // If there is alloca command we need to check if the latest memory is in
    // required context.
    if (isSameCtx) {
      // If the memory is already in the required host context, check if the
      // required access mode is valid, remap if not.
      if (Record->MCurContext->is_host() &&
          !isAccessModeAllowed(Req->MAccessMode, Record->MHostAccess)) {
        remapMemoryObject(Record, Req,
                          Req->MIsSubBuffer
                              ? (static_cast<AllocaSubBufCommand *>(AllocaCmd))
                                    ->getParentAlloca()
                              : AllocaCmd,
                          ToEnqueue);
      }
    } else {
      // Cannot directly copy memory from OpenCL device to OpenCL device -
      // create two copies: device->host and host->device.
      bool NeedMemMoveToHost = false;
      auto MemMoveTargetQueue = Queue;
 
      if (isInteropTask) {
        const detail::CGHostTask &HT = static_cast<detail::CGHostTask &>(CG);
 
        if (HT.MQueue->getContextImplPtr() != Record->MCurContext) {
          NeedMemMoveToHost = true;
          MemMoveTargetQueue = HT.MQueue;
        }
      } else if (!Queue->is_host() && !Record->MCurContext->is_host())
        NeedMemMoveToHost = true;
 
      if (NeedMemMoveToHost)
        insertMemoryMove(Record, Req,
                         Scheduler::getInstance().getDefaultHostQueue(),
                         ToEnqueue);
      insertMemoryMove(Record, Req, MemMoveTargetQueue, ToEnqueue);
    }
    std::set<Command *> Deps =
        findDepsForReq(Record, Req, Queue->getContextImplPtr());
 
    for (Command *Dep : Deps) {
      if (Dep != NewCmd) {
        Command *ConnCmd =
            NewCmd->addDep(DepDesc{Dep, Req, AllocaCmd}, ToCleanUp);
        if (ConnCmd)
          ToEnqueue.push_back(ConnCmd);
      }
    }
  }
 
  // Set new command as user for dependencies and update leaves.
  // Node dependencies can be modified further when adding the node to leaves,
  // iterate over their copy.
  // FIXME employ a reference here to eliminate copying of a vector
  std::vector<DepDesc> Deps = NewCmd->MDeps;
  for (DepDesc &Dep : Deps) {
    const Requirement *Req = Dep.MDepRequirement;
    MemObjRecord *Record = getMemObjRecord(Req->MSYCLMemObj);
    updateLeaves({Dep.MDepCommand}, Record, Req->MAccessMode, ToCleanUp);
    addNodeToLeaves(Record, NewCmd, Req->MAccessMode, ToEnqueue);
  }
 
  // Register all the events as dependencies
  for (detail::EventImplPtr e : Events) {
    if (e->getCommand() && e->getCommand() == NewCmd) {
      continue;
    }
    if (Command *ConnCmd = NewCmd->addDep(e, ToCleanUp))
      ToEnqueue.push_back(ConnCmd);
  }
 
  if (MPrintOptionsArray[AfterAddCG])
    printGraphAsDot("after_addCG");
 
  for (Command *Cmd : ToCleanUp) {
    cleanupCommand(Cmd);
  }
}
 
void Scheduler::GraphBuilder::decrementLeafCountersForRecord(
    MemObjRecord *Record) {
  for (Command *Cmd : Record->MReadLeaves) {
    --(Cmd->MLeafCounter);
    if (Cmd->readyForCleanup())
      cleanupCommand(Cmd);
  }
  for (Command *Cmd : Record->MWriteLeaves) {
    --(Cmd->MLeafCounter);
    if (Cmd->readyForCleanup())
      cleanupCommand(Cmd);
  }
}
 
void Scheduler::GraphBuilder::cleanupCommandsForRecord(MemObjRecord *Record) {
  std::vector<AllocaCommandBase *> &AllocaCommands = Record->MAllocaCommands;
  if (AllocaCommands.empty())
    return;
 
  assert(MCmdsToVisit.empty());
  MVisitedCmds.clear();
 
  // First, mark all allocas for deletion and their direct users for traversal
  // Dependencies of the users will be cleaned up during the traversal
  for (Command *AllocaCmd : AllocaCommands) {
    markNodeAsVisited(AllocaCmd, MVisitedCmds);
 
    for (Command *UserCmd : AllocaCmd->MUsers)
      // Linked alloca cmd may be in users of this alloca. We're not going to
      // visit it.
      if (UserCmd->getType() != Command::CommandType::ALLOCA)
        MCmdsToVisit.push(UserCmd);
      else
        markNodeAsVisited(UserCmd, MVisitedCmds);
 
    AllocaCmd->MMarks.MToBeDeleted = true;
    // These commands will be deleted later, clear users now to avoid
    // updating them during edge removal
    AllocaCmd->MUsers.clear();
  }
 
  // Make sure the Linked Allocas are marked visited by the previous walk.
  // Remove allocation commands from the users of their dependencies.
  for (AllocaCommandBase *AllocaCmd : AllocaCommands) {
    AllocaCommandBase *LinkedCmd = AllocaCmd->MLinkedAllocaCmd;
 
    if (LinkedCmd) {
      assert(LinkedCmd->MMarks.MVisited);
    }
 
    for (DepDesc &Dep : AllocaCmd->MDeps)
      if (Dep.MDepCommand)
        Dep.MDepCommand->MUsers.erase(AllocaCmd);
  }
 
  // Traverse the graph using BFS
  while (!MCmdsToVisit.empty()) {
    Command *Cmd = MCmdsToVisit.front();
    MCmdsToVisit.pop();
 
    if (!markNodeAsVisited(Cmd, MVisitedCmds))
      continue;
 
    for (Command *UserCmd : Cmd->MUsers)
      if (UserCmd->getType() != Command::CommandType::ALLOCA)
        MCmdsToVisit.push(UserCmd);
 
    // Delete all dependencies on any allocations being removed
    // Track which commands should have their users updated
    std::map<Command *, bool> ShouldBeUpdated;
    auto NewEnd = std::remove_if(
        Cmd->MDeps.begin(), Cmd->MDeps.end(), [&](const DepDesc &Dep) {
          if (std::find(AllocaCommands.begin(), AllocaCommands.end(),
                        Dep.MAllocaCmd) != AllocaCommands.end()) {
            ShouldBeUpdated.insert({Dep.MDepCommand, true});
            return true;
          }
          ShouldBeUpdated[Dep.MDepCommand] = false;
          return false;
        });
    Cmd->MDeps.erase(NewEnd, Cmd->MDeps.end());
 
    // Update users of removed dependencies
    for (auto DepCmdIt : ShouldBeUpdated) {
      if (!DepCmdIt.second)
        continue;
      DepCmdIt.first->MUsers.erase(Cmd);
    }
 
    // If all dependencies have been removed this way, mark the command for
    // deletion
    if (Cmd->MDeps.empty()) {
      Cmd->MUsers.clear();
      // Do not delete the node if it's scheduled for post-enqueue cleanup to
      // avoid double free.
      if (!Cmd->MMarkedForCleanup)
        Cmd->MMarks.MToBeDeleted = true;
    }
  }
 
  handleVisitedNodes(MVisitedCmds);
}
 
void Scheduler::GraphBuilder::cleanupCommand(
    Command *Cmd, [[maybe_unused]] bool AllowUnsubmitted) {
  if (SYCLConfig<SYCL_DISABLE_POST_ENQUEUE_CLEANUP>::get()) {
    static bool DeprWarningPrinted = false;
    if (!DeprWarningPrinted) {
      std::cerr << "WARNING: The enviroment variable "
                   "SYCL_DISABLE_POST_ENQUEUE_CLEANUP is deprecated. Please "
                   "use SYCL_DISABLE_EXECUTION_GRAPH_CLEANUP instead.\n";
      DeprWarningPrinted = true;
    }
    return;
  }
  if (SYCLConfig<SYCL_DISABLE_EXECUTION_GRAPH_CLEANUP>::get())
    return;
 
  assert(Cmd->MLeafCounter == 0 &&
         (Cmd->isSuccessfullyEnqueued() || AllowUnsubmitted));
  Command::CommandType CmdT = Cmd->getType();
 
  assert(CmdT != Command::ALLOCA && CmdT != Command::ALLOCA_SUB_BUF);
  assert(CmdT != Command::RELEASE);
  (void)CmdT;
 
  for (Command *UserCmd : Cmd->MUsers) {
    for (DepDesc &Dep : UserCmd->MDeps) {
      // Link the users of the command to the alloca command(s) instead
      if (Dep.MDepCommand == Cmd) {
        // ... unless the user is the alloca itself.
        if (Dep.MAllocaCmd == UserCmd) {
          Dep.MDepCommand = nullptr;
        } else {
          Dep.MDepCommand = Dep.MAllocaCmd;
          Dep.MDepCommand->MUsers.insert(UserCmd);
        }
      }
    }
  }
  // Update dependency users
  for (DepDesc &Dep : Cmd->MDeps) {
    Command *DepCmd = Dep.MDepCommand;
    DepCmd->MUsers.erase(Cmd);
  }
 
  if (Cmd->getType() == Command::FUSION &&
      !static_cast<KernelFusionCommand *>(Cmd)->readyForDeletion()) {
    // Fusion commands might still be needed because fusion might be aborted,
    // but a later call to complete_fusion still needs to be able to return a
    // valid event. Clean-up of fusion commands is therefore explicitly handled
    // by start fusion.
    return;
  }
  Cmd->getEvent()->setCommand(nullptr);
  delete Cmd;
}
 
void Scheduler::GraphBuilder::removeRecordForMemObj(SYCLMemObjI *MemObject) {
  const auto It = std::find_if(
      MMemObjs.begin(), MMemObjs.end(),
      [MemObject](const SYCLMemObjI *Obj) { return Obj == MemObject; });
  if (It != MMemObjs.end())
    MMemObjs.erase(It);
  MemObject->MRecord.reset();
}
 
// Make Cmd depend on DepEvent from different context. Connection is performed
// via distinct ConnectCmd with host task command group on host queue. Cmd will
// depend on ConnectCmd's host event.
// DepEvent may not have a command associated with it in at least two cases:
//  - the command was deleted upon cleanup process;
//  - DepEvent is user event.
// In both of these cases the only thing we can do is to make ConnectCmd depend
// on DepEvent.
// Otherwise, when there is a command associated with DepEvent, we make
// ConnectCmd depend on on this command. If there is valid, i.e. non-nil,
// requirement in Dep we make ConnectCmd depend on DepEvent's command with this
// requirement.
// Optionality of Dep is set by Dep.MDepCommand equal to nullptr.
Command *Scheduler::GraphBuilder::connectDepEvent(
    Command *const Cmd, const EventImplPtr &DepEvent, const DepDesc &Dep,
    std::vector<Command *> &ToCleanUp) {
  assert(Cmd->getWorkerContext() != DepEvent->getContextImpl());
 
  // construct Host Task type command manually and make it depend on DepEvent
  ExecCGCommand *ConnectCmd = nullptr;
 
  try {
    std::unique_ptr<detail::HostTask> HT(new detail::HostTask);
    std::unique_ptr<detail::CG> ConnectCG(new detail::CGHostTask(
        std::move(HT), /* Queue = */ {}, /* Context = */ {}, /* Args = */ {},
        detail::CG::StorageInitHelper(
            /* ArgsStorage = */ {}, /* AccStorage = */ {},
            /* SharedPtrStorage = */ {}, /* Requirements = */ {},
            /* DepEvents = */ {DepEvent}),
        CG::CodeplayHostTask,
        /* Payload */ {}));
    ConnectCmd = new ExecCGCommand(
        std::move(ConnectCG), Scheduler::getInstance().getDefaultHostQueue());
  } catch (const std::bad_alloc &) {
    throw runtime_error("Out of host memory", PI_ERROR_OUT_OF_HOST_MEMORY);
  }
 
  if (Dep.MDepRequirement) {
    // make ConnectCmd depend on requirement
    // Dismiss the result here as it's not a connection now,
    // 'cause ConnectCmd is host one
    (void)ConnectCmd->addDep(Dep, ToCleanUp);
    assert(reinterpret_cast<Command *>(DepEvent->getCommand()) ==
           Dep.MDepCommand);
    // add user to Dep.MDepCommand is already performed beyond this if branch
    {
      DepDesc DepOnConnect = Dep;
      DepOnConnect.MDepCommand = ConnectCmd;
 
      // Dismiss the result here as it's not a connection now,
      // 'cause ConnectCmd is host one
      std::ignore = Cmd->addDep(DepOnConnect, ToCleanUp);
    }
  } else {
    // It is required condition in another a path and addUser will be set in
    // addDep
    if (Command *DepCmd = reinterpret_cast<Command *>(DepEvent->getCommand()))
      DepCmd->addUser(ConnectCmd);
 
    std::ignore = ConnectCmd->addDep(DepEvent, ToCleanUp);
 
    std::ignore = Cmd->addDep(ConnectCmd->getEvent(), ToCleanUp);
 
    ConnectCmd->addUser(Cmd);
  }
 
  return ConnectCmd;
}
 
void Scheduler::GraphBuilder::startFusion(QueueImplPtr Queue) {
  cleanUpCmdFusion(Queue.get());
  auto QUniqueID = std::hash<sycl::detail::queue_impl *>()(Queue.get());
  MFusionMap.emplace(QUniqueID, std::make_unique<KernelFusionCommand>(Queue));
}
 
void Scheduler::GraphBuilder::cleanUpCmdFusion(
    sycl::detail::queue_impl *Queue) {
  auto QUniqueID = std::hash<sycl::detail::queue_impl *>()(Queue);
  if (isInFusionMode(QUniqueID)) {
    throw sycl::exception{sycl::make_error_code(sycl::errc::invalid),
                          "Queue already in fusion mode"};
  }
  auto OldFusionCmd = findFusionList(QUniqueID);
  if (OldFusionCmd != MFusionMap.end()) {
    // If fusion was used on this queue previously, the old fusion command might
    // still be around to make sure that even after
    // cancellation of the fusion due to synchronization, complete_fusion is
    // still able to return a valid event.
    OldFusionCmd->second->setFusionStatus(
        KernelFusionCommand::FusionStatus::DELETED);
    cleanupCommand(OldFusionCmd->second.release());
    MFusionMap.erase(OldFusionCmd);
  }
}
 
void Scheduler::GraphBuilder::removeNodeFromGraph(
    Command *Node, std::vector<Command *> &ToEnqueue) {
  // Remove the placeholder command as leaf of all its requirements and from the
  // user list of all its dependencies.
  for (auto &Dep : Node->MDeps) {
    auto AccessMode = Dep.MDepRequirement->MAccessMode;
    auto *Record = getMemObjRecord(Dep.MDepRequirement->MSYCLMemObj);
 
    Node->MLeafCounter -= Record->MReadLeaves.remove(Node);
    Node->MLeafCounter -= Record->MWriteLeaves.remove(Node);
    // If the placeholder had a write-requirement on this record, we need to
    // restore the previous leaves.
    if (AccessMode != access::mode::read) {
      for (auto PrevDep : Dep.MDepCommand->MDeps) {
        auto *DepReq = PrevDep.MDepRequirement;
        auto *DepRecord = getMemObjRecord(DepReq->MSYCLMemObj);
        if (DepRecord == Record) {
          // Need to restore this as a leaf, because we pushed it from the
          // leaves when adding the placeholder command.
          assert(Dep.MDepCommand);
          addNodeToLeaves(Record, Dep.MDepCommand, DepReq->MAccessMode,
                          ToEnqueue);
        }
      }
    }
    Dep.MDepCommand->MUsers.erase(Node);
  }
 
  // Clear all the dependencies to avoid cleanDepEventsThroughOneLevel, called
  // from the destructor of the command to delete the dependencies of the
  // command this command depends on.
  Node->clearAllDependencies();
}
 
void Scheduler::GraphBuilder::cancelFusion(QueueImplPtr Queue,
                                           std::vector<Command *> &ToEnqueue) {
  auto QUniqueID = std::hash<sycl::detail::queue_impl *>()(Queue.get());
  if (!isInFusionMode(QUniqueID)) {
    return;
  }
  auto FusionList = findFusionList(QUniqueID);
 
  auto *PlaceholderCmd = (*FusionList).second.get();
 
  // Enqueue all the kernels/commands from the fusion list
  auto FusedCmdList = PlaceholderCmd->getFusionList();
  ToEnqueue.insert(ToEnqueue.end(), FusedCmdList.begin(), FusedCmdList.end());
 
  // The commands establishing an event dependency between the fusion
  // placeholder command and the individual kernels need to be enqueued.
  ToEnqueue.insert(ToEnqueue.end(), PlaceholderCmd->auxiliaryCommands().begin(),
                   PlaceholderCmd->auxiliaryCommands().end());
 
  ToEnqueue.push_back(PlaceholderCmd);
 
  if (MPrintOptionsArray[AfterFusionCancel]) {
    printGraphAsDot("after_fusionCancel");
  }
 
  // Set the status for the fusion command
  PlaceholderCmd->setFusionStatus(KernelFusionCommand::FusionStatus::CANCELLED);
}
 
static bool isPartOfFusion(Command *Cmd, KernelFusionCommand *Fusion) {
  if (Cmd->getType() == Command::RUN_CG) {
    return static_cast<ExecCGCommand *>(Cmd)->MFusionCmd == Fusion;
  }
  return false;
}
 
static bool checkForCircularDependency(Command *, bool, KernelFusionCommand *);
 
static bool createsCircularDependency(Command *Cmd, bool PredPartOfFusion,
                                      KernelFusionCommand *Fusion) {
  if (isPartOfFusion(Cmd, Fusion)) {
    // If this is part of the fusion and the predecessor also was, we can stop
    // the traversal here. A direct dependency between two kernels in the same
    // fusion will never form a cyclic dependency and by iterating over all
    // commands in a fusion, we will detect any cycles originating from the
    // current command.
    // If the predecessor was not part of the fusion, but the current command
    // is, we have found a potential cycle in the dependency graph.
    return !PredPartOfFusion;
  }
  return checkForCircularDependency(Cmd, false, Fusion);
}
 
static bool checkForCircularDependency(Command *Cmd, bool IsPartOfFusion,
                                       KernelFusionCommand *Fusion) {
  // Check the requirement dependencies.
  for (auto &Dep : Cmd->MDeps) {
    auto *DepCmd = Dep.MDepCommand;
    if (!DepCmd) {
      continue;
    }
    if (createsCircularDependency(DepCmd, IsPartOfFusion, Fusion)) {
      return true;
    }
  }
  for (auto &Ev : Cmd->getPreparedDepsEvents()) {
    auto *EvDepCmd = static_cast<Command *>(Ev->getCommand());
    if (!EvDepCmd) {
      continue;
    }
    if (createsCircularDependency(EvDepCmd, IsPartOfFusion, Fusion)) {
      return true;
    }
  }
  for (auto &Ev : Cmd->getPreparedHostDepsEvents()) {
    auto *EvDepCmd = static_cast<Command *>(Ev->getCommand());
    if (!EvDepCmd) {
      continue;
    }
    if (createsCircularDependency(EvDepCmd, IsPartOfFusion, Fusion)) {
      return true;
    }
  }
  return false;
}
 
EventImplPtr
Scheduler::GraphBuilder::completeFusion(QueueImplPtr Queue,
                                        std::vector<Command *> &ToEnqueue,
                                        const property_list &PropList) {
  auto QUniqueID = std::hash<sycl::detail::queue_impl *>()(Queue.get());
#if SYCL_EXT_CODEPLAY_KERNEL_FUSION
  if (!isInFusionMode(QUniqueID)) {
    auto InactiveFusionList = findFusionList(QUniqueID);
    if (InactiveFusionList == MFusionMap.end()) {
      throw sycl::exception{
          sycl::make_error_code(sycl::errc::invalid),
          "Calling complete_fusion on a queue not in fusion mode"};
    }
    return InactiveFusionList->second->getEvent();
  }
 
  auto FusionList = findFusionList(QUniqueID);
  auto *PlaceholderCmd = FusionList->second.get();
  auto &CmdList = PlaceholderCmd->getFusionList();
 
  // If there is more than one queue currently in fusion mode, we need to check
  // if fusing the kernel would create a circular dependency. A circular
  // dependency would arise, if a kernel in the fusion list *indirectly* depends
  // on another kernel in the fusion list. Here, indirectly means, that the
  // dependency is created through a third command not part of the fusion, on
  // which this kernel depends and which in turn depends on another kernel in
  // fusion list.
  //
  // Note that we only have to consider dependencies via fusion queues here:
  // Let K1 be a kernel submitted to a queue Q1 in fusion mode. If a kernel K2
  // is submitted to a non-fusion queue Q2 and K2 depends on K1, fusion on Q1 is
  // cancelled automatically.
  bool CreatesCircularDep =
      MFusionMap.size() > 1 &&
      std::any_of(CmdList.begin(), CmdList.end(), [&](ExecCGCommand *Cmd) {
        return checkForCircularDependency(Cmd, true, PlaceholderCmd);
      });
  if (CreatesCircularDep) {
    // If fusing would create a fused kernel, cancel the fusion.
    printFusionWarning(
        "Aborting fusion because it would create a circular dependency");
    auto LastEvent = PlaceholderCmd->getEvent();
    this->cancelFusion(Queue, ToEnqueue);
    return LastEvent;
  }
 
  // Call the JIT compiler to generate a new fused kernel.
  auto FusedCG = detail::jit_compiler::get_instance().fuseKernels(
      Queue, CmdList, PropList);
 
  if (!FusedCG) {
    // If the JIT compiler returns a nullptr, JIT compilation of the fused
    // kernel failed. In that case, simply cancel the fusion and run each kernel
    // on its own.
    auto LastEvent = PlaceholderCmd->getEvent();
    this->cancelFusion(Queue, ToEnqueue);
    return LastEvent;
  }
 
  // Inherit all event dependencies from the input commands in the fusion list.
  std::vector<EventImplPtr> FusedEventDeps;
  for (auto *Cmd : CmdList) {
    FusedEventDeps.insert(FusedEventDeps.end(),
                          Cmd->getPreparedDepsEvents().begin(),
                          Cmd->getPreparedDepsEvents().end());
    FusedEventDeps.insert(FusedEventDeps.end(),
                          Cmd->getPreparedHostDepsEvents().begin(),
                          Cmd->getPreparedHostDepsEvents().end());
  }
 
  // Remove internal explicit dependencies, i.e., explicit dependencies from one
  // kernel in the fusion list to another kernel also in the fusion list.
  FusedEventDeps.erase(
      std::remove_if(FusedEventDeps.begin(), FusedEventDeps.end(),
                     [&](EventImplPtr &E) {
                       if (E->getCommand() == PlaceholderCmd) {
                         return true;
                       }
                       if (E->getCommand() &&
                           static_cast<Command *>(E->getCommand())->getType() ==
                               Command::RUN_CG) {
                         auto *RunCGCmd =
                             static_cast<ExecCGCommand *>(E->getCommand());
                         if (RunCGCmd->MFusionCmd == PlaceholderCmd) {
                           return true;
                         }
                       }
                       return false;
                     }),
      FusedEventDeps.end());
 
  auto FusedKernelCmd =
      std::make_unique<ExecCGCommand>(std::move(FusedCG), Queue);
 
  // Inherit auxiliary resources from fused command groups
  Scheduler::getInstance().takeAuxiliaryResources(FusedKernelCmd->getEvent(),
                                                  PlaceholderCmd->getEvent());
  assert(PlaceholderCmd->MDeps.empty());
  // Next, backwards iterate over all the commands in the fusion list and remove
  // them from the graph to restore the state before starting fusion, so we can
  // add the fused kernel to the graph in the next step.
  // Clean up the old commands after successfully fusing them.
  for (auto OldCmd = CmdList.rbegin(); OldCmd != CmdList.rend(); ++OldCmd) {
    removeNodeFromGraph(*OldCmd, ToEnqueue);
    cleanupCommand(*OldCmd, /* AllowUnsubmitted */ true);
  }
 
  createGraphForCommand(FusedKernelCmd.get(), FusedKernelCmd->getCG(), false,
                        FusedKernelCmd->getCG().getRequirements(),
                        FusedEventDeps, Queue, ToEnqueue);
 
  ToEnqueue.push_back(FusedKernelCmd.get());
 
  std::vector<Command *> ToCleanUp;
  // Make the placeholder command depend on the execution of the fused kernel
  auto *ConnectToPlaceholder =
      PlaceholderCmd->addDep(FusedKernelCmd->getEvent(), ToCleanUp);
  if (ConnectToPlaceholder) {
    ToEnqueue.push_back(ConnectToPlaceholder);
  }
  for (Command *Cmd : ToCleanUp) {
    cleanupCommand(Cmd);
  }
  ToEnqueue.push_back(PlaceholderCmd);
 
  if (MPrintOptionsArray[AfterFusionComplete]) {
    printGraphAsDot("after_fusionComplete");
  }
 
  // Set the status for the fusion command.
  PlaceholderCmd->setFusionStatus(KernelFusionCommand::FusionStatus::COMPLETE);
 
  return FusedKernelCmd.release()->getEvent();
#else  // SYCL_EXT_CODEPLAY_KERNEL_FUSION
  printFusionWarning("Kernel fusion not supported by this build");
  (void)PropList;
  auto FusionList = findFusionList(QUniqueID);
  auto *PlaceholderCmd = FusionList->second.get();
  auto LastEvent = PlaceholderCmd->getEvent();
  this->cancelFusion(Queue, ToEnqueue);
  return LastEvent;
#endif // SYCL_EXT_CODEPLAY_KERNEL_FUSION
}
 
bool Scheduler::GraphBuilder::isInFusionMode(QueueIdT Id) {
  auto FusionList = findFusionList(Id);
  if (FusionList == MFusionMap.end()) {
    return false;
  }
  return FusionList->second->isActive();
}
 
Command *Scheduler::GraphBuilder::addCommandGraphUpdate(
    ext::oneapi::experimental::detail::exec_graph_impl *Graph,
    std::vector<std::shared_ptr<ext::oneapi::experimental::detail::node_impl>>
        Nodes,
    const QueueImplPtr &Queue, std::vector<Requirement *> Requirements,
    std::vector<detail::EventImplPtr> &Events,
    std::vector<Command *> &ToEnqueue) {
  auto NewCmd =
      std::make_unique<UpdateCommandBufferCommand>(Queue, Graph, Nodes);
  // If there are multiple requirements for the same memory object, its
  // AllocaCommand creation will be dependent on the access mode of the first
  // requirement. Combine these access modes to take all of them into account.
  combineAccessModesOfReqs(Requirements);
  std::vector<Command *> ToCleanUp;
  for (Requirement *Req : Requirements) {
    MemObjRecord *Record = nullptr;
    AllocaCommandBase *AllocaCmd = nullptr;
 
    bool isSameCtx = false;
 
    {
 
      Record = getOrInsertMemObjRecord(Queue, Req, ToEnqueue);
      markModifiedIfWrite(Record, Req);
 
      AllocaCmd = getOrCreateAllocaForReq(Record, Req, Queue, ToEnqueue);
 
      isSameCtx = sameCtx(Queue->getContextImplPtr(), Record->MCurContext);
    }
 
    if (!isSameCtx) {
      // Cannot directly copy memory from OpenCL device to OpenCL device -
      // create two copies: device->host and host->device.
      bool NeedMemMoveToHost = false;
      auto MemMoveTargetQueue = Queue;
 
      if (!Queue->is_host() && !Record->MCurContext->is_host())
        NeedMemMoveToHost = true;
 
      if (NeedMemMoveToHost)
        insertMemoryMove(Record, Req,
                         Scheduler::getInstance().getDefaultHostQueue(),
                         ToEnqueue);
      insertMemoryMove(Record, Req, MemMoveTargetQueue, ToEnqueue);
    }
    std::set<Command *> Deps =
        findDepsForReq(Record, Req, Queue->getContextImplPtr());
 
    for (Command *Dep : Deps) {
      if (Dep != NewCmd.get()) {
        Command *ConnCmd =
            NewCmd->addDep(DepDesc{Dep, Req, AllocaCmd}, ToCleanUp);
        if (ConnCmd)
          ToEnqueue.push_back(ConnCmd);
      }
    }
  }
 
  // Set new command as user for dependencies and update leaves.
  // Node dependencies can be modified further when adding the node to leaves,
  // iterate over their copy.
  // FIXME employ a reference here to eliminate copying of a vector
  std::vector<DepDesc> Deps = NewCmd->MDeps;
  for (DepDesc &Dep : Deps) {
    const Requirement *Req = Dep.MDepRequirement;
    MemObjRecord *Record = getMemObjRecord(Req->MSYCLMemObj);
    updateLeaves({Dep.MDepCommand}, Record, Req->MAccessMode, ToCleanUp);
    addNodeToLeaves(Record, NewCmd.get(), Req->MAccessMode, ToEnqueue);
  }
 
  // Register all the events as dependencies
  for (detail::EventImplPtr e : Events) {
    if (e->getCommand() &&
        e->getCommand() == static_cast<Command *>(NewCmd.get())) {
      continue;
    }
    if (Command *ConnCmd = NewCmd->addDep(e, ToCleanUp))
      ToEnqueue.push_back(ConnCmd);
  }
 
  if (MPrintOptionsArray[AfterAddCG])
    printGraphAsDot("after_addCG");
 
  for (Command *Cmd : ToCleanUp) {
    cleanupCommand(Cmd);
  }
 
  return NewCmd.release();
}
 
} // namespace detail
} // namespace _V1
} // namespace sycl